Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Update go from 1.13 to 1.14. (#2013)"" #2029

Merged
merged 4 commits into from
Jun 26, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented May 1, 2020

This re-enables go 1.14. This PR is awaiting a boltdb bump as described in cortexproject/cortex#2480

@codecov-io
Copy link

Codecov Report

Merging #2029 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2029      +/-   ##
==========================================
+ Coverage   63.83%   63.99%   +0.15%     
==========================================
  Files         133      133              
  Lines       10200    10200              
==========================================
+ Hits         6511     6527      +16     
+ Misses       3202     3184      -18     
- Partials      487      489       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/tailer.go 76.13% <0.00%> (-2.28%) ⬇️
pkg/promtail/targets/filetarget.go 70.12% <0.00%> (+1.82%) ⬆️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

@cyriltovena
Copy link
Contributor

Can you mark as WIP please

@stale
Copy link

stale bot commented May 31, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label May 31, 2020
@cyriltovena cyriltovena added the keepalive An issue or PR that will be kept alive and never marked as stale. label Jun 1, 2020
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Jun 1, 2020
Signed-off-by: Cyril Tovena <[email protected]>
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 7682b32 into grafana:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants